Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support of reject_old_samples and reject_old_samples_max_age in favour of Out Of Order Samples support #4990

Closed
alvinlin123 opened this issue Nov 23, 2022 · 1 comment
Closed

Remove support of reject_old_samples and reject_old_samples_max_age in favour of Out Of Order Samples support #4990

alvinlin123 opened this issue Nov 23, 2022 · 1 comment
Labels
type/chore Something that needs to be done; not a bug or a feature

Comments

@alvinlin123
Copy link
Member

We are likely to release out of order sample support in Release 1.15, which deprecates reject_old_samples and reject_old_samples_max_age. As promised in https://cortexmetrics.io/docs/configuration/v1guarantees/, we will keep the deprecated flags for 2 minor releases, so we will remove the 2 flags in release 1.17.
@alvinlin123 alvinlin123 added this to the Release 1.17 milestone Nov 23, 2022
@alvinlin123 alvinlin123 added the type/chore Something that needs to be done; not a bug or a feature label Nov 23, 2022
@yeya24
Copy link
Contributor

yeya24 commented Dec 28, 2022

Based on the dicussion from #4964, the new OOO feature cannot cover all use cases of reject_old_samples and reject_old_samples_max_age so let's not deprecate these flags for now.

@yeya24 yeya24 closed this as completed Mar 23, 2023
@friedrichg friedrichg removed this from the Release 1.17 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvinlin123 @friedrichg @yeya24