Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to series/metadata limits with 400 instead of 429 in the ingester. #3827

Closed
stevesg opened this issue Feb 15, 2021 · 1 comment · Fixed by #3833
Closed

React to series/metadata limits with 400 instead of 429 in the ingester. #3827

stevesg opened this issue Feb 15, 2021 · 1 comment · Fixed by #3833

Comments

@stevesg
Copy link
Contributor

stevesg commented Feb 15, 2021

Is your feature request related to a problem? Please describe.
Currently Cortex responds from the write path with 429 in the distributor (upon being rate limited) and the ingester (when series or metadata limits are reached). Rate limiting in the distributor is recoverable, and so a client can choose to respond to the 429 by retrying. The ingester limits, are not recoverable, and retrying is wasteful.

Describe the solution you'd like
We should make a change so that only the distributor responds with the 429, as it would be sensible to retry these. The ingester limits are not recoverable, and so should respond with another distinct 4xx code such as 400.

Describe alternatives you've considered
None, though for Prometheus specifically, a workaround is being introduced to phase the introduction of retry behavior:
prometheus/prometheus#8477

Additional context
Context about why this is significant can be found here:
prometheus/prometheus#8237

@pracucci
Copy link
Contributor

pracucci commented Feb 15, 2021

👍 on this. You can also find a related discussion on CNCF Slack.

@stevesg stevesg changed the title React to series/metata limits with 400 instead of 429 in the ingestor. React to series/metata limits with 400 instead of 429 in the ingester. Feb 15, 2021
@stevesg stevesg changed the title React to series/metata limits with 400 instead of 429 in the ingester. React to series/metadata limits with 400 instead of 429 in the ingester. Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants