Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Disable modules that cause reader errors instead of aborting #475

Open
Tracked by #476
traunts opened this issue Dec 19, 2022 · 1 comment
Open
Tracked by #476

Disable modules that cause reader errors instead of aborting #475

traunts opened this issue Dec 19, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request refactor Code needs to be refactored

Comments

@traunts
Copy link
Collaborator

traunts commented Dec 19, 2022

Current Behaviour:

When loading a DataModule, as soon as the reader encounters an invalid ini entry, it triggers an abort and reports the offending line to the user.
This abort may also be triggered during other module loading steps (eg: SupportedGameVersion mismatch).

Feature:

In most cases, when an error/assertion is triggered while loading a new non-official DataModule, the game shall continue to load with that module disabled rather than aborting.

@traunts traunts added enhancement New feature or request refactor Code needs to be refactored labels Dec 19, 2022
@traunts traunts self-assigned this Dec 19, 2022
@Causeless
Copy link

I'd note that it should probably continue attempting to load the module and spit all errors to console, so that if there are multiple issues the modder can fix them all in one go (instead of restarting the game and checking 1 error at a time).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request refactor Code needs to be refactored
Projects
None yet
Development

No branches or pull requests

2 participants