Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback wanted: Increase the Minimum supported Cmake version #168

Closed
jschwe opened this issue Apr 13, 2022 · 5 comments
Closed

Feedback wanted: Increase the Minimum supported Cmake version #168

jschwe opened this issue Apr 13, 2022 · 5 comments

Comments

@jschwe
Copy link
Collaborator

jschwe commented Apr 13, 2022

The Minimum CMake version will likely be increased for v0.3. At the very least we are considering dropping support for CMake 3.12, but requiring CMake 3.16 or even 3.18 is also on the table. If you are using a CMake version that would be no longer supported by corrosion, please comment here so that I can gauge the number of affected users.

This issue will be mentioned in the Release notes for v0.2, so everyone who reads release notes should have the opportunity to voice themselves.

@heinrich5991
Copy link

Debian 10 (without backports) includes CMake 3.13.4 (https://repologoy.org/project/cmake/versions). Debian 10 is still supported until 2024 (https://en.wikipedia.org/w/index.php?title=Debian_version_history&oldid=1089641928#Release_table).

Would you accept patches for backward compatibility in case I start using this? My project tries to support Debian.

@jschwe
Copy link
Collaborator Author

jschwe commented May 26, 2022

Do you need any new features (i.e. something that is not supported yet by corrosion), or would it be acceptable for you to stay on a v0.2 branch and just backport any Bugfixes as needed to that branch?

@heinrich5991
Copy link

No, I probably don't need new features.

@jwoolston
Copy link

We use corrosion in a mixed x86/Arm environment. The Arm builds are with Buildroot versions which currently limit us to CMake 3.16 which is equivalent to the "standard" provided by Ubuntu 20.04 (our official development environment).

@jschwe
Copy link
Collaborator Author

jschwe commented Oct 27, 2022

Corrosion will keep its minimum supported version at CMake 3.15 for the v0.3 release (and likely also beyond that). However some features are and will be gated behind a version feature gate.

@jschwe jschwe closed this as completed Oct 27, 2022
@jschwe jschwe unpinned this issue Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants