Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

TEK Exports should not contain any keys which recently expired #367

Closed
christian-kirschnick opened this issue May 29, 2020 · 2 comments · Fixed by #386
Closed

TEK Exports should not contain any keys which recently expired #367

christian-kirschnick opened this issue May 29, 2020 · 2 comments · Fixed by #386
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@christian-kirschnick
Copy link
Member

christian-kirschnick commented May 29, 2020

Currently the system also packages keys, which expired recently. Instead, only keys which have been expired since at least 2 hours should be part of the export.

Can also be a nice prework for #108.

Probably should change this already when the diagnosis keys are queried for distribution:
https://github.com/corona-warn-app/cwa-server/blob/master/common/persistence/src/main/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyService.java#L64

@christian-kirschnick christian-kirschnick added the enhancement New feature or request label May 29, 2020
@christian-kirschnick christian-kirschnick added this to the RTC milestone May 29, 2020
@pithumke
Copy link
Member

Apple spec states:

[Your EN Server...] must not distribute temporary exposure key data until at least 2 hours after the end of the keyʼs expiration window

I think this is a subtle but important difference to just excluding (+2h) by submission timestamp. As far as I know, the TEK API on-device does not give out "still active" keys to the app. This just leaves a 2 hour window that depends on the rolling start interval number and the rolling period, but not on the submission timestamp.

@christian-kirschnick
Copy link
Member Author

You are right Pit - I just talked to DPP to clarify whether this is OK for them, and it is.

I'll update the description of the issue accordingly.

@christian-kirschnick christian-kirschnick changed the title TEK Exports should not contain any keys which were submitted recently TEK Exports should not contain any keys which recently expired May 29, 2020
@UnchartedBull UnchartedBull self-assigned this May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants