Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Scanning qrcode for result #576

Closed
MarcusCoding opened this issue Jun 17, 2020 · 6 comments
Closed

Scanning qrcode for result #576

MarcusCoding opened this issue Jun 17, 2020 · 6 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@MarcusCoding
Copy link

Describe the bug

One of my colleagues tried to scan a simple QR Code with the url "https://forum.test-test.de/forum/qrcode/index.php?id=22" inside.

Example qr-code with the provided url from above inside ;)
https://imgur.com/a/GYJtnJJ

PS:
The number behind id=X can only be registered once.

Expected behaviour

A error should come up, that the qrcode is not valid. But it was registered as a valid test result.

Steps to reproduce the issue

  1. Open the app
  2. Go to "have you been tested?"
  3. Choose the otpion "document with qr-code"
  4. Scan the provided qr-code

Technical details

  • Huawei Mate 20 Pro running Android 10 on EMUI 10.0.0 (app version 1.0.0)
@MarcusCoding MarcusCoding added the bug Something isn't working label Jun 17, 2020
@IndianaDschones
Copy link
Contributor

I cannot reproduce this. I get the following error message:

Error
The QR code/TAN is invalid [...]

Nokia 6.1, Android 10

@MarcusCoding
Copy link
Author

Hello @IndianaDschones ,

could you try it again with this qr-code?

https://imgur.com/a/XpZuw46

Thanks, the qr-code with the id=22 was already tested by us, this one should work.

@IndianaDschones
Copy link
Contributor

You´re right. Now it is indeed recognized as an valid QR code. It states that my result is not available

@MarcusCoding
Copy link
Author

Hello @IndianaDschones ,

I have the same message:
"Ergebnis liegt noch nicht vor".

So it is registered as a valid qr-code but without a result.

@jakobmoellerdev jakobmoellerdev added the wontfix This will not be worked on label Jun 17, 2020
@kolyaopahle
Copy link
Contributor

Hey,
this is actually intended behaviour to mitigate brute force attacks against the backend. You are able to register any kind of id as a "valid" test but the result will always return as peding without resolving.

@daimpi
Copy link

daimpi commented Aug 3, 2020

@kolyaopahle : Could you elaborate a bit more, how this behavior mitigates against brute-force?
Would there be an option to at least show an error, if the QR Code is fundamentally not CWA compatible?
B/c if this relies solely on the user, using the right app they will get confused. (See e.g. here: https://twitter.com/TristanKretsch1/status/1290315954304495618)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants