Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Volume renders incorrectly when webWorkerManager is initialized before rendering #888

Closed
sgielen opened this issue Nov 14, 2023 · 3 comments

Comments

@sgielen
Copy link
Contributor

sgielen commented Nov 14, 2023

Describe the Bug

If cornerstoneDICOMImageLoader.webWorkerManager.initialize is called before rendering the first volume, the volume is rendered incorrectly.

Steps to Reproduce

A reproduction scenario is available at: https://sjorsgielen.nl/cornerstone3d/webworkermanager-init.zip

Unpack this .zip file, run yarn install and yarn dev, then browse to the indicated port.

The current behavior

The volume will be extremely bright (at least for me).
If initWebWorkers is set to false at the top of src/main.ts, it is rendered normally.

The expected behavior

It does not matter whether the web workers are initialized ahead-of-time or not.

OS

macOS 14.0

Node version

20.8.1

Browser

Safari 17.0

@sedghi
Copy link
Member

sedghi commented Dec 14, 2023

This relates to the same issue you're experiencing with other matters, specifically regarding wadouri, scaling, and metadata concerns.

Let's begin by addressing the scaling problem, and then we can tackle the other issues. Currently, I'm a bit short on time to prioritize this, but I'm more than happy to assist you with reviewing and providing guidance.

@sgielen
Copy link
Contributor Author

sgielen commented Dec 16, 2023

Thank you @sedghi! I am currently away for a few weeks, but when I get back, I would like to continue with these. With the scaling issue, do you mean #887? If so, I will start with that one when I am back.

@sgielen
Copy link
Contributor Author

sgielen commented Nov 1, 2024

I can't reproduce this anymore now that I'm on Cornerstone3D 2.0, so I believe this has been fixed since then. Probably since the prescaling was enabled by default on main.

@sgielen sgielen closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants