Fix interpolated inline styles #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit excludes `tag-event-attribute` and `tag-style-attribute` contexts from Svelte components as both haven't default HTML meaning and embedded syntax definitions might cause conflicts.
This commit... 1. creates dedicated CSS syntax to handle single and double quoted inline style attribute values. 2. and includes them into required html tag attribute values, replacing existing "embed" statements. That's required to support nested quotation marks within interpolation.
deathaxe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
This PR excludes
tag-event-attributeandtag-style-attributecontexts from Svelte components as both haven't default HTML meaning and embedded syntax definitions might cause conflicts.