Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how Linux flavor is determined for generating systemv init script #31

Open
tacooper opened this issue Apr 19, 2016 · 2 comments
Open

Fix how Linux flavor is determined for generating systemv init script #31

tacooper opened this issue Apr 19, 2016 · 2 comments

Comments

@tacooper
Copy link

In lib/systemv.js, the output of "cat /proc/version" is parsed for certain Redhat or Debian strings. This does not work for all Linux builds.

The standard method for init scripts is to check for either of the "/etc/redhat-release" or "/etc/debian-version" files, since they only exist in their respective Linux flavors.

Hopefully this is easy to fix, since your service does not work with our current Redhat or Debian Linux builds (although Debian is the default flavor so it ends up generating the right script for it).
@tacooper tacooper mentioned this issue Aug 19, 2016
Closed
@tacooper
Copy link
Author

finally got some time to work on this... I'll submit a pull request soon!

@tacooper tacooper mentioned this issue Jan 24, 2017
Open
@tacooper
Copy link
Author

@coreybutler anyone able to review the related PR #38? just casually revisiting this open ticket years later ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tacooper