fix: remove most uses of log.Fatal when running programatically #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
changed the title
jcchavezs
approved these changes
Oct 31, 2022
theseion
reviewed
Nov 2, 2022
| assert.LessOrEqual(t, 0, res.Stats.TotalFailed(), "Oops, test run failed!") | ||
| } | ||
|
|
||
| func TestDisabledRun(t *testing.T) { | ||
| t.Cleanup(config.Reset) | ||
|
|
||
| err := config.NewConfigFromString(yamlConfig) | ||
| err := config.NewConfigFromString(yamlCloudConfig) |
There was a problem hiding this comment.
Why did you have to change the config here?
There was a problem hiding this comment.
Thanks for checking forgot to mention it previously the presence of a log file was checked lazily so if we the test didn't run, like this one checking behavior of disabled tests, it was ok without a log file set. Now that validation is eager, which should generally be good. It seemed simplest to use cloud mode here which doesn't need a log file instead of setting up an unused file
fzipi
pushed a commit
that referenced
this pull request
Nov 2, 2022
Propagate errors instead of exiting immediately
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-ftw provides a programmatic entry point for tests like this one
https://github.com/corazawaf/coraza/blob/v3/dev/testing/coreruleset/coreruleset_test.go#L213
There are some quirks like global config (will look at in another PR) and the code causing the process to exit because of use of
log.Fatal, making test failures difficult to understand. This replaceslog.Fatalwith propagating errors. There is one remaining Fatal for a regexp which will require some less mechanical change but that also should have lower chance of triggering