feat: use goreleaser default naming for published archives #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
approved these changes
Oct 7, 2022
|
Does the naming change? If it does, can you provide also a PR for https://github.com/coreruleset/coreruleset/blob/cf383e1625c973bdc673307790be99ecbcbe8314/.github/workflows/go-ftw.yml#L28 so we can merge when releasing? |
|
@anuraaga ☝️ ? |
|
Sorry for delay @fzipi sent coreruleset/coreruleset#2846 |
fzipi
approved these changes
Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just style so no worries if not going with this. I want to propose using goreleaser default naming scheme for release archives. goreleaser is very common now, and I like the consistency of archive names I see across various projects when writing tooling. I think it's worth doing that here.
Also publishes a windows-amd64 build (not arm64 since there is no viable platform for that yet)