Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: testoverride ignore/forcefail/forcepass as regexes #80

Merged
merged 15 commits into from
Oct 13, 2022
Merged

feat: testoverride ignore/forcefail/forcepass as regexes #80

merged 15 commits into from
Oct 13, 2022

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Sep 23, 2022 •
edited
Loading

In this PR:

  • ignore, forcefail and forcepass lists are now considered regexes.
  • Updated example inside the readme accordingly

Closes #75.

@M4tteoP M4tteoP mentioned this pull request Sep 23, 2022
Closed
@M4tteoP M4tteoP changed the title [WIP] Implementation of ignore/forcefail/forcepass as regexes Implementation of ignore/forcefail/forcepass as regexes Oct 3, 2022
@M4tteoP M4tteoP marked this pull request as ready for review October 3, 2022 20:33
@M4tteoP M4tteoP changed the title Implementation of ignore/forcefail/forcepass as regexes feat: testoverride ignore/forcefail/forcepass as regexes Oct 4, 2022
@fzipi
Copy link
Member

fzipi commented Oct 4, 2022

I guess you should rebase after moving to a new organization.

anuraaga
anuraaga reviewed Oct 5, 2022
View reviewed changes
config/types.go Outdated Show resolved Hide resolved
theseion
theseion requested changes Oct 5, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
config/types.go Outdated Show resolved Hide resolved
anuraaga
anuraaga reviewed Oct 11, 2022
View reviewed changes
check/base.go Outdated Show resolved Hide resolved
anuraaga
anuraaga previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

theseion
theseion requested changes Oct 12, 2022
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
config/types.go Outdated Show resolved Hide resolved
@theseion theseion requested a review from anuraaga October 12, 2022 19:07
@anuraaga anuraaga merged commit b636c28 into coreruleset:main Oct 13, 2022
@fzipi fzipi mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore/forcefail/forcepass as regexes
4 participants
@M4tteoP @fzipi @anuraaga @theseion