Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override options poorly documented? #59

Closed
dkegel-fastly opened this issue Aug 7, 2022 · 2 comments · Fixed by #65
Closed

override options poorly documented? #59

dkegel-fastly opened this issue Aug 7, 2022 · 2 comments · Fixed by #65
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@dkegel-fastly
Copy link
Contributor

dkegel-fastly commented Aug 7, 2022

go-ftw and ftw before it both seem to assume the server being tested is at localhost:80.

The python ftw seems to have options to change that, e.g. --destaddr=domain.com --port 443 --protocol https, at least when run with test/test_default.py (I guess that was its equivalent of cloud mode).

So does go-ftw -- see applyInputOverride and config_test.go -- but the feature appears to be poorly documented,
with no example in README.md.

@dkegel-fastly dkegel-fastly changed the title cloud mode could use --destaddr etc. options override options poorly documented? Aug 7, 2022
@theseion theseion added the documentation Improvements or additions to documentation label Aug 15, 2022
@theseion
Copy link
Collaborator

Thanks @dkegel-fastly. That part hasn't been really tested, which is probably why it's not documented. But you're right, it should be.

@fzipi fzipi self-assigned this Aug 30, 2022
@fzipi
Copy link
Member

fzipi commented Aug 30, 2022

Good find, will add it to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants