Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate raw input in tests #408

Open
fzipi opened this issue Nov 27, 2024 · 2 comments
Open

deprecate raw input in tests #408

fzipi opened this issue Nov 27, 2024 · 2 comments

Comments

@fzipi
Copy link
Member

fzipi commented Nov 27, 2024

We have been using and recommending encoded instead. We should deprecate raw input in tests and remove all the logic we have for that in go-ftw.
@theseion
Copy link
Collaborator

We've already deprecated it: https://github.com/coreruleset/ftw-tests-schema/blob/7bee5e866b34465b2f9f226c9f3be34581cadd2a/types/types.go#L294. You mean, we should remove it for good now?

@fzipi
Copy link
Member Author

fzipi commented Nov 28, 2024

I think we should. There is code that we have for handling it that we can remove...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theseion @fzipi