This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
azure: Remove Scale Sets implementation #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were some requests for keeping Scale Sets support, back when we switched to Availability Sets. So I guess we can get rid of it for now and plan to back-port from AS. |
alexsomesan
previously approved these changes
Aug 9, 2017
|
Can we keep the |
justaugustus
force-pushed
the
remove-scalesets
branch
2 times, most recently
from
20541ba
to
1e0a1f8
Compare
|
@alexsomesan Fixed. Thanks for the review! |
justaugustus
force-pushed
the
remove-scalesets
branch
from
1e0a1f8
to
d2f954e
Compare
|
@alexsomesan Rebased to fix |
|
Setting do-not-test since this code is not exercised from anywhere. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what everyone's thoughts are, but we're not using any of the Azure Scale Set code.
This PR removes it.
cc: @alexsomesan @s-urbaniak @mxinden @metral