[merged] Add infrastructure for alternative name (currently nts) #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See coreos#405 This patch adds an (off by default) `--enable-new-name` build option which currently defaults to `nts`. This is purely additive, and the intention is that we'll support the rpm-ostree name in perpetuity most likely. At the moment, we add a new name for: - /usr/bin/$name - The systemd unit file But we notably *don't* attempt to add a new name to the DBus API, as it'd be a lot more invasive of a patch, and less payoff (it's mostly just programs/scripts that interact with the DBus).
jlebon
approved these changes
Oct 19, 2016
| mv $(DESTDIR)$(bindir)/rpm-ostree $(DESTDIR)$(bindir)/$(primaryname) | ||
| ln -sf $(primaryname) $(DESTDIR)$(bindir)/rpm-ostree | ||
| if BUILDOPT_NEW_NAME | ||
| INSTALL_DATA_HOOKS += install-bin-hook |
There was a problem hiding this comment.
Though this should be ultimately be using install-exec-hook, no? So i.e. have a new analogous INSTALL_EXEC_HOOKS? But meh, not sure in what circumstances this would actually matter.
There was a problem hiding this comment.
From the automake manual:
Automake generates separate 'install-data' and 'install-exec' rules, in
case the installer is installing on multiple machines that share
directory structure--these targets allow the machine-independent parts to
be installed only once.
But I feel confident in saying basically no one does that. Even the people who try it are going to be using binary rpms/debs/images, since not everything in the world uses automake.
There was a problem hiding this comment.
So basically I just put everything under install-data-hook.
|
OK, that makes sense! |
|
☀️ Test successful - status-atomicjenkins |
rh-atomic-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #405
This patch adds an (off by default)
--enable-new-namebuild optionwhich currently defaults to
nts. This is purely additive, andthe intention is that we'll support the rpm-ostree name in
perpetuity most likely.
At the moment, we add a new name for:
But we notably don't attempt to add a new name to the DBus API,
as it'd be a lot more invasive of a patch, and less payoff (it's
mostly just programs/scripts that interact with the DBus).