Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpacker: Fix a 32 bit format string error #215

Merged
merged 1 commit into from
Feb 24, 2016
Merged

unpacker: Fix a 32 bit format string error #215

merged 1 commit into from
Feb 24, 2016

Conversation

cgwalters
Copy link
Member

No description provided.

@cgwalters
Copy link
Member Author

bot, retest this please

@mbarnes
Copy link
Contributor

mbarnes commented Feb 23, 2016

👍 Patch is correct despite the failing checks.

@jlebon
Copy link
Member

jlebon commented Feb 23, 2016

Huh, this should pass. I had the same failure in #209 and it was fixed in one of the fixups.

@jlebon
Copy link
Member

jlebon commented Feb 23, 2016

Ahhh, this is failing for a different reason. The exact failure is:

ERROR: tests/test-ucontainer.sh
===============================

error: /usr/libexec/installed-tests/rpm-ostree/tests/compose/yum was not found

That repo doesn't exist because it hasn't been installed yet (since it's running before make install). Seems like the test has to be adapted to use the in-tree version for make check.

@cgwalters
Copy link
Member Author

bot, retest this please

1 similar comment
@cgwalters
Copy link
Member Author

bot, retest this please

cgwalters added a commit that referenced this pull request Feb 24, 2016
@cgwalters
Merge pull request #215 from cgwalters/unpacker-32
78d0bbb 
unpacker: Fix a 32 bit format string error
@cgwalters cgwalters merged commit 78d0bbb into coreos:master Feb 24, 2016
@cgwalters
Copy link
Member Author

Eh, dunno what's wrong with the bot, the test seems to be passing (as we'd expect). Merging anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgwalters @mbarnes @jlebon