Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rpm-ostree install -A error message when override detected #3728

Open
BeeGrech opened this issue Jun 6, 2022 · 4 comments
Open

Improve rpm-ostree install -A error message when override detected #3728

BeeGrech opened this issue Jun 6, 2022 · 4 comments

Comments

@BeeGrech
Copy link

BeeGrech commented Jun 6, 2022

Expected vs actual behavior

# rpm-ostree override replace ./kernel*.rpm
...install successful 
# rpm-ostree -A --allow-inactive --idempotent install kernel*-devel
error: packages would be changed: 6, enable replacement to override

but rpm -q --whatprovides returns the package installed
*note no reboot was performed after the override replace

Expected:

# rpm-ostree install kernel-*-devel 
...
Successfully updated running filesystem tree.

Steps to reproduce it

I hesitated writing this up because the error makes sense, since the current commit has not been booted yet from the updated kernel. However, ultimately the package at the correct updated version is installed so I believe this situation should at least be documented or handled. In that the Error return causes a misconception.

If a reboot is performed, this entire condition is not observed (rightfully so).

Please let me know of additional information needed

Would you like to work on the issue?
can not at this time

@jlebon
Copy link
Member

jlebon commented Jun 6, 2022

I think the first code block is missing a -A in the rpm-ostree install invocation, right?

The way apply-live works, you can keep accumulating changes in the pending deployment without rebooting, but live applying will only ever try to keep applying changes from the pending deployment to the current one. There's no way currently to have rpm-ostree install work only on the booted deployment, but I agree it'd make sense to add (but it'd have to be a separate switch).

@BeeGrech
Copy link
Author

BeeGrech commented Jun 6, 2022

@jlebon you got me there, yes, I am calling -A on the extra packages
-A install --allow-inactive --idempotent
to be exact

@BeeGrech
Copy link
Author

BeeGrech commented Jun 8, 2022

The concern I had was more around the error message, as it leads the user and/or any automation to think the package has not been installed.... but it has

@jlebon jlebon changed the title rpm-ostree override replace of kernel without a reboot causes extra kernel package install to return in error Improve rpm-ostree install -A error message when override detected Jun 8, 2022
@cgwalters
Copy link
Member

I'd put this in #2883 basically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants