Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when setting log level #90

Open
jkessler93 opened this issue Jan 25, 2019 · 3 comments
Open

Race condition when setting log level #90

jkessler93 opened this issue Jan 25, 2019 · 3 comments

Comments

@jkessler93
Copy link

When setting the log level, Go detects a race condition between lines capnslog/logmap.go:212 and capnslog/pkg_logger.go:158. I think there should be a read lock before checking the log level in the functions in pkg_logger.

@lucab
Copy link
Contributor

lucab commented Jan 26, 2019

@jkessler93 if your application is a consumer of those modules, please beware of #57 (comment).

@jkessler93
Copy link
Author

@lucab thanks for letting me know! Any idea when it might be removed?

@lucab
Copy link
Contributor

lucab commented Jan 30, 2019

@jkessler93 I don't think it is going to be removed anytime soon due to the number of still-existing consumers. But if you are starting a new project or actively developing something, please consider not using this module as it won't receive much development/maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants