-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capnslog: Capnslog should default to using stdlib "log" #26
Comments
This turns out to be very important even in situations where you DO set up capnslog in your main module: testing. Unless you specifically set up capnslog in your test code, it will silently swallow all logs, making it hard to debug stuff. |
@bobbyrullo is this fixed by #28? |
It seems to. I'll have to try it out to make sure. |
It's not fixed. Sorry for not trying it out before, but it still swallows messages when no formatter has been set. |
Feel free to reprioritize this - I thought it was swallowing errors from tests, which it is not (that would've been a p0), but it still swallows messages from the rest of the app. I'll take a look and see if I can do a quick fix. |
Not sure if this issue is related to: etcd-io/etcd#4115 (comment) |
This way, people who import libraries which use capnslog but don't explicitly set it up still get logging.
The text was updated successfully, but these errors were encountered: