Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capnslog: Capnslog should default to using stdlib "log" #26

Open
bobbyrullo opened this issue Jun 10, 2015 · 6 comments
Open

capnslog: Capnslog should default to using stdlib "log" #26

bobbyrullo opened this issue Jun 10, 2015 · 6 comments
Assignees

Comments

@bobbyrullo
Copy link
Contributor

This way, people who import libraries which use capnslog but don't explicitly set it up still get logging.

@bobbyrullo
Copy link
Contributor Author

This turns out to be very important even in situations where you DO set up capnslog in your main module: testing. Unless you specifically set up capnslog in your test code, it will silently swallow all logs, making it hard to debug stuff.

@jonboulle
Copy link
Contributor

@bobbyrullo is this fixed by #28?

@bobbyrullo
Copy link
Contributor Author

It seems to. I'll have to try it out to make sure.

@bobbyrullo
Copy link
Contributor Author

It's not fixed. Sorry for not trying it out before, but it still swallows messages when no formatter has been set.

@bobbyrullo
Copy link
Contributor Author

Feel free to reprioritize this - I thought it was swallowing errors from tests, which it is not (that would've been a p0), but it still swallows messages from the rest of the app. I'll take a look and see if I can do a quick fix.

@purpleidea
Copy link
Contributor

Not sure if this issue is related to: etcd-io/etcd#4115 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants