Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Comment regular expression is fragile #29

Open
ripla opened this issue Feb 7, 2018 · 0 comments
Open

Comment regular expression is fragile #29

ripla opened this issue Feb 7, 2018 · 0 comments

Comments

@ripla
Copy link

ripla commented Feb 7, 2018

In some comments in our repository the comments regexp in comments.go fails to match at all, and sync fails since fields is empty.

As a ugly quickfix I had to add

if len(fields) != 5 {
		log.Debug("Failed to update JIRA comment for ", jIssue.ID)
		return nil
	}

To UpdateComment to make sync work. Also writing the config to home failed on macOS, but worked when I specified a full file path. I can add a separate issue about that if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant