This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add new ignition-fetch-offline.service #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2020
jlebon
force-pushed
the
pr/fetch-offline
branch
2 times, most recently
from
11025db to
5ab91da
Compare
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 30, 2020
We want to move to a model where networking isn't unconditionally brought up, but instead only if Ignition requires it. Works with: coreos/fedora-coreos-config#321 coreos/ignition-dracut#164 coreos/ignition#956
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Mar 30, 2020
We want to move to a model where networking isn't unconditionally brought up, but instead only if Ignition requires it. But I think we'll still have to keep supporting `ignition_network_kcmdline` since it's kind of part of our API now that it can be overridden via `ignition.firstboot`. Works with: coreos/fedora-coreos-config#321 coreos/ignition-dracut#164 coreos/ignition#956
jlebon
commented
Mar 30, 2020
jlebon
changed the title
|
OK, this is the next PR in the list for conditional networking (coreos/fedora-coreos-tracker#443)! |
dustymabe
reviewed
Jun 12, 2020
|
Updated for comments! |
bgilbert
reviewed
Jun 18, 2020
dustymabe
reviewed
Jun 18, 2020
dustymabe
approved these changes
Jun 18, 2020
Make use of the new `fetch-offline` stage: coreos/ignition#979 We run this between the `setup` and `fetch` stages (the latter possibly being skipped if networking is not required). We hit the same issue here that `coreos-copy-firstboot-network.service` hit, which is that we can't run before the `cmdline` hook because that runs *before* udev, but we want the `by-*` symlinks for `ignition-setup-user.service`. The hack we do here is to rerun the NM cmdline hook in case ignition dropped a snippet in `/etc/cmdline.d`. As mentioned in coreos/fedora-coreos-config#346, we'll be able to do this more cleanly once we run NM as a systemd service directly.
No reason to leak this outside the function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the new
fetch-offlinestage:coreos/ignition#979
We run this between the
setupandfetchstages (the latter possiblybeing skipped if networking is not required).
We hit the same issue here that
coreos-copy-firstboot-network.servicehit, which is that we can't run before the
cmdlinehook because thatruns before udev, but we want the
by-*symlinks forignition-setup-user.service.The hack we do here is to rerun the NM cmdline hook in case ignition
dropped a snippet in
/etc/cmdline.d. As mentioned incoreos/fedora-coreos-config#346, we'll be able
to do this more cleanly once we run NM as a systemd service directly.