Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which case for FCCT #176

Closed
ajeddeloh opened this issue May 8, 2019 · 3 comments
Closed

Which case for FCCT #176

ajeddeloh opened this issue May 8, 2019 · 3 comments

Comments

@ajeddeloh
Copy link
Contributor

The Fedora CoreOS Config Transpiler (FCCT) will read FCCs and emit Ignition configs (see #129). This mirrors how with Container Linux is configured with CLCs and the Container Linux Config Transpiler (CLCT).

Ignition uses camelCase in it's config currently. CLCT uses snake_case. We should pick one for FCCT.

I'm not what will be more confusing: using a different case than Ignition or being different than CLCT.

Worth calling out we can change Ignition with a major spec bump, but that's a lot of churn and I'd like to avoid it if possible.

@dustymabe
Copy link
Member

From the meeting today jonathan and I both had this opinion:

a slight preference for dash-case overall, but between camelCase and
snake_case i'd rather the latter

@ajeddeloh
Copy link
Contributor Author

FWIW I also prefer snake case, though very weakly. Talking with @crawford he thinks using snake case with yaml and camel case with json is pretty standard. Snake case also is also what cloudinit uses, so that's a tiny bit less friction for those coming from cloudinit-land.

I'm going to close this out in favor of snake case by EOD friday if no one has a strong case the other way.

@bgilbert bgilbert mentioned this issue May 9, 2019
8 tasks
@ajeddeloh
Copy link
Contributor Author

Closing in favor of snake_case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants