Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep/Remove Python dependent package: nfs-utils #121

Closed
sinnykumari opened this issue Jan 17, 2019 · 19 comments
Closed

Keep/Remove Python dependent package: nfs-utils #121

sinnykumari opened this issue Jan 17, 2019 · 19 comments
Labels
-python card related to removing a python dependency

Comments

@sinnykumari
Copy link
Contributor

sinnykumari commented Jan 17, 2019

FCOS community members are trying not to ship Python in base system. In ticket #92, we have identified list of Python dependent packages which are currently installed in FCOS.

This ticket is to investigate that do we really need nfs-utils in FCOS base system? If yes, how can we provide nfs-utils or equivalent functionalities without shipping Python.

@bgilbert
Copy link
Contributor

nfs-utils-2.3.3-1.rc1.fc29.x86_64 contains two Python scripts: /usr/sbin/mountstats and /usr/sbin/nfsiostat. Perhaps they could be broken out into a subpackage.

@dustymabe dustymabe added the -python card related to removing a python dependency label Jan 17, 2019
@sinnykumari
Copy link
Contributor Author

@bgilbert Would be interested in filing a RFE bug against nfs-utils package?

@bgilbert
Copy link
Contributor

@sinnykumari You probably shouldn't wait for me. 🙂

@sinnykumari
Copy link
Contributor Author

RFE bug to make separate sub-package for Python utilities - https://bugzilla.redhat.com/show_bug.cgi?id=1667889

@sinnykumari
Copy link
Contributor Author

Latest nfs-utils package available in F30 includes a Python script nfsconvert.py which is required to convert deprecated sysconfig/nfs configuration into /etc/nfs.conf .
From the related nfs-utils bug, so far feasible option is to rewrite nfsconvert.py script into any compile language.
@dustymabe @cgwalters @bgilbert Have any better suggestion about bug ? I am not sure that it is feasible to ship FCOS without nfs-utils.

@dustymabe
Copy link
Member

thanks @sinnykumari - we can talk about this in the next meeting.

@dustymabe dustymabe added the meeting topics for meetings label Feb 4, 2019
@dustymabe
Copy link
Member

We chatted about this in the community meeting yesterday and we decided to accept the proposal to make a nfs-utils-coreos package.

There are still conversations going on in the BZ exploring possibilities, but in general a new package is acceptable.

@bgilbert bgilbert removed the meeting topics for meetings label Feb 12, 2019
@dustymabe dustymabe added the meeting topics for meetings label Feb 13, 2019
@dustymabe
Copy link
Member

Update from BZ discussion:

The nfs team created a nfs-utils-coreos package for us that just contains the nfs client. My action item is to find out if FCOS needs to ship the server or is just the client OK?

Other open questions from the BZ:

  • if it is ok for FCOS to ship just the client would the package be
    useful to anyone else other than FCOS? If so then maybe renaming it
    to nfs-client-utils and splitting the server out to a separate package
    as well would be useful so that other people may use it

@bgilbert bgilbert removed the meeting topics for meetings label Feb 13, 2019
@dustymabe
Copy link
Member

Discussed in the meeting today.

We agreed on the following statement:

AGREED: we think shipping only the nfs client will suffice
    considering users can run nfs server in a container 

@dustymabe
Copy link
Member

FYI f30 and f31 rpm builds with nfs-utils-coreos rpm in them:

https://koji.fedoraproject.org/koji/taskinfo?taskID=32925998

https://koji.fedoraproject.org/koji/taskinfo?taskID=32926002

@ajeddeloh
Copy link
Contributor

closed via coreos/fedora-coreos-config#84

@remoe
Copy link

remoe commented May 28, 2020

@dustymabe , the predecessor of FCOS has NFS server included :/ Does anyone know a "stable" NFS-server container for FCOS?

@dustymabe
Copy link
Member

I don't know of one off hand. Anyone else?

@jlebon
Copy link
Member

jlebon commented Jun 2, 2020

This might fall under #401.

@remoe
Copy link

remoe commented Jun 3, 2020

Here is a nfs-server contribution :) I've tried https://github.com/ehough/docker-nfs-server . The fcct for nfsv4:

variant: fcos
version: 1.0.0 
storage:
  files:
    - path: /etc/modules-load.d/nfs.conf
      mode: 0660
      contents:
        inline: |
          nfs
          nfsd
systemd:
  units: 
    - name: nfs-server.service
      enabled: true
      contents: |
        [Unit]
        Description=NFS Server
        After=network-online.target
        Wants=network-online.target

        [Service]
        Environment=REGISTRY_AUTH_FILE=<your path>/.docker/config.json
        TimeoutStartSec=0
        ExecStartPre=-/bin/podman kill nfs-server
        ExecStartPre=-/bin/podman rm nfs-server
        ExecStartPre=/bin/podman pull <your repos>
        ExecStart=/bin/podman run --rm --name nfs-server \
          --cap-add SYS_ADMIN --cap-add SYS_MODULE \
          -e NFS_LOG_LEVEL=DEBUG \
          -p 2049:2049 \
          ${data_volume_mounts} -v ${exports_file}:/etc/exports:Z -v /lib/modules:/lib/modules:ro --security-opt label=disable \
          <your repos>
        KillMode=none
        Type=simple
        [Install]
        WantedBy=multi-user.target

data_volume_mounts, exports_file, <your repos> and <your path> must be replaced with your settings.

@kai-uwe-rommel
Copy link

kai-uwe-rommel commented Jul 15, 2020

I think that FCOS should have a NFS server included in its base package.
AFAIK it runs better if not in a container, because of kernel module support?

But I agree that having Python as a dependency for just a NFS server is ridiculous.

@diabl0w
Copy link

diabl0w commented Nov 13, 2020

Here is a nfs-server contribution :) I've tried https://github.com/ehough/docker-nfs-server . The fcct for nfsv4:

variant: fcos
version: 1.0.0 
storage:
  files:
    - path: /etc/modules-load.d/nfs.conf
      mode: 0660
      contents:
        inline: |
          nfs
          nfsd
systemd:
  units: 
    - name: nfs-server.service
      enabled: true
      contents: |
        [Unit]
        Description=NFS Server
        After=network-online.target
        Wants=network-online.target

        [Service]
        Environment=REGISTRY_AUTH_FILE=<your path>/.docker/config.json
        TimeoutStartSec=0
        ExecStartPre=-/bin/podman kill nfs-server
        ExecStartPre=-/bin/podman rm nfs-server
        ExecStartPre=/bin/podman pull <your repos>
        ExecStart=/bin/podman run --rm --name nfs-server \
          --cap-add SYS_ADMIN --cap-add SYS_MODULE \
          -e NFS_LOG_LEVEL=DEBUG \
          -p 2049:2049 \
          ${data_volume_mounts} -v ${exports_file}:/etc/exports:Z -v /lib/modules:/lib/modules:ro --security-opt label=disable \
          <your repos>
        KillMode=none
        Type=simple
        [Install]
        WantedBy=multi-user.target

data_volume_mounts, exports_file, <your repos> and <your path> must be replaced with your settings.

this is going to be maintained by the FCOS team? I really need a permanent/stable nfs server solution for my FCOS deployments

@LorbusChris
Copy link
Contributor

@diabl0w I think this is a good candidate for inclusion in the docs. However we cannot support container images that are not built in the Fedora ecosystem. If you can come up with a working fedora-container based Dockerfile, I'm happy to help you get it into Fedora's container registry.

@diabl0w
Copy link

diabl0w commented Nov 13, 2020

@diabl0w I think this is a good candidate for inclusion in the docs. However we cannot support container images that are not built in the Fedora ecosystem. If you can come up with a working fedora-container based Dockerfile, I'm happy to help you get it into Fedora's container registry.

Thanks for the response, unfortunately I am not qualified to be doing that, haha. I've been just following the rabbit hole of a few issues being linked to running an nfs server inside coreos. It seems like the only solution for now is running a 3rd party container, until the nfs-server nfs-client rpms get sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-python card related to removing a python dependency
Projects
None yet
Development

No branches or pull requests

9 participants