Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdmain: backport support for different certs for etcd-gRPC proxy #9894

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

xmudrii
Copy link
Contributor

@xmudrii xmudrii commented Jul 2, 2018

This PR proposes backporting support for different certs for the etcd-gRPC proxy. The feature has been already introduced in #8277, but not backported to v3.2.

This PR cherry-picks 1365f87d4046469bcc94ad03048a52b8b4367bb0, as well as e5531a4d54e89338e35994ee1c7e69c87c18d0e8, as it introduced some changes in the gRPC-proxy code.

The efbee9d8c788e434cae8da03b03ad55f5a6f67c5 and c5447c2ec91bc349117327de9f7f019cf6cdf1b5 commits have not been cherry-picked, as they require changes to the TLS part of the code. I wanted to keep this PR minimal, with changes only made to the gRPC-Proxy feature, in order to prevent the backwards-compatibility issues.

This PR adds the most important features to enable securing the etcd-gRPC proxy. If you'd like, I can add those two commits as well.

Without flags introduced in this PR, it's not possible (or not that easy) to secure the etcd exposed by etcd-gRPC proxy v3.2.

For example, my GSoC project–etcdproxy-controller exposes etcd for Kubernetes API servers using the etcd-gRPC proxy. When working in production environments, it's very important to have etcd secured, but to keep it fully-compatible with Kubernetes, which is still on v3.2, we should use v3.2 images, that doesn't support TLS in the etcd-gRPC proxy.

I would like to know what do you think about this proposal and is it possible to backport the feature to v3.2.

Anthony Romano and others added 2 commits July 2, 2018 11:20
@sttts
Copy link
Contributor

sttts commented Jul 2, 2018

👍

@gyuho
Copy link
Contributor

gyuho commented Jul 2, 2018

@xmudrii Could you also add this change to https://github.com/coreos/etcd/blob/master/CHANGELOG-3.2.md?

@xmudrii
Copy link
Contributor Author

xmudrii commented Jul 2, 2018

@gyuho No problem but not sure at all how to do it. I have created this PR against release-3.2 branch, as those commits already exists on master and release-3.3. The releases-3.2 doesn't have the CHANGELOG.

Should I create a new PR? Is there some guidelines for backporting to older versions?

@gyuho
Copy link
Contributor

gyuho commented Jul 2, 2018

@xmudrii Yes. Separate PR should work. Thanks!

@xmudrii
Copy link
Contributor Author

xmudrii commented Jul 2, 2018

@gyuho Created #9896 to update the changelog.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for contribution @xmudrii !

@gyuho gyuho merged commit d22ee84 into etcd-io:release-3.2 Jul 2, 2018
gyuho added a commit that referenced this pull request Jul 2, 2018
Update CHANGELOG-3.2 to include changes from #9894
@xmudrii xmudrii deleted the 3.2-grpcproxy-tls branch July 2, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants