etcdctl/v3: add lease keep-alive --once flag #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Yeah, simple e2e test case would be good. We can write one around https://github.com/coreos/etcd/blob/master/e2e/ctl_v3_lease_test.go#L75. |
|
Sorry, I didn't got it. Am I supposed to write the test? If yes, then should I create a second pull request? |
|
@marcovc You can add another commit for the test. Thanks! |
|
@gyuho, I added the test, although as far as I understand it simply tests if the command runs, and not if it does what is expected. But so does the other tests in that file. I called the "test" binary but I'm not sure the test was called. Let me know if you need anything else. |
|
lgtm. defer to @xiang90 |
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8719