clientv3: use waitgroup to wait for substream goroutine teardown #7582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a grpc watch stream is torn down, it will join on its logical substream goroutines by waiting for each to close a channel. This doesn't guarantee the substream is fully exited, though, but only about to exit and can be waiting to resume even after Watch.Close finishes. Instead, use a waitgroup.Done at the very end of the substream defer. Fixes etcd-io#7573
|
lgtm |
1 similar comment
|
lgtm |
|
might be worth backporting, but kind of minor issue |
|
@heyitsanthony Yeah was going to ask. Let's backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a grpc watch stream is torn down, it will join on its logical substream
goroutines by waiting for each to close a channel. This doesn't guarantee
the substream is fully exited, though, but only about to exit and can be
waiting to resume even after Watch.Close finishes. Instead, use a
waitgroup.Done at the very end of the substream defer.
Fixes #7573
reproduced reliably by allocating 10x more watch channels in TestWatchStressResumeClose