wal: fsync directory after wal file rename #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
force-pushed
the
fix-wal-rename
branch
from
6c9d2a7 to
c108b9d
Compare
|
lgtm |
heyitsanthony
force-pushed
the
fix-wal-rename
branch
6 times, most recently
from
985346d to
bd7107b
Compare
added 2 commits
September 8, 2016 00:09
Windows needs to open a directory with write access to fsync but the go runtime won't open directories that way.
| return os.NewFile(uintptr(fd), path), nil | ||
| } | ||
|
|
||
| func openDir(path string) (fd syscall.Handle, err error) { |
There was a problem hiding this comment.
this seems to be right. but i am not a window expert...
There was a problem hiding this comment.
Yeah, I was testing on a VM to figure this out. The joy of windows.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6368