etcdserver, embed: stricter reconfig checking #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we have an e2e test for this feature yet? |
|
nope, I'll see about adding some |
heyitsanthony
force-pushed
the
strict-reconfig-healthy
branch
from
f08210f
to
8c8e4f4
Compare
|
Added an integration test; e2e would've been kind of messy. /cc @xiang90 |
heyitsanthony
force-pushed
the
strict-reconfig-healthy
branch
from
8c8e4f4
to
bf3d704
Compare
|
|
||
| // all attempts to add member should fail | ||
| for i := 1; i < len(c.Members); i++ { | ||
| if err := c.addMemberByURL(t, c.URL(i), "unix://foo:12345"); err == nil { |
There was a problem hiding this comment.
check the exact error? if err != xxx
There was a problem hiding this comment.
the error's kind of misleading; it gets turned into a no leader error because the api gives a 500 error and the client converts it...
There was a problem hiding this comment.
can do add comment and a todo to fix this?
There was a problem hiding this comment.
I'll just fix it now instead of reusing the not enough started error message...
There was a problem hiding this comment.
punting on this, using the comment+TODO; change would be too involved for this patch
|
lgtm |
heyitsanthony
force-pushed
the
strict-reconfig-healthy
branch
from
bf3d704
to
9063ce5
Compare
Make --strict-reconfig-check a default and check if cluster is healthy when adding a member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make --strict-reconfig-check a default and check if cluster is healthy when adding a member.