e2e: add basic upgrade tests #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
changed the title
| @@ -58,6 +58,7 @@ function unit_tests { | |||
|
|
|||
| function integration_tests { | |||
| echo "Running integration tests..." | |||
| MIGRATION_FROM=v3.0.2 | |||
There was a problem hiding this comment.
This might be better with environmental variable. I put this just for this PR to test it in the CI.
gyuho
force-pushed
the
release-test
branch
6 times, most recently
from
255aa7f to
4ead59a
Compare
|
@heyitsanthony @xiang90 Please review. This adds basic migration tests that I do manually for releases. |
| @@ -57,7 +57,16 @@ function unit_tests { | |||
| } | |||
|
|
|||
| function integration_tests { | |||
| echo "Running integration tests..." | |||
| MIGRATION_TEST="v3.0.2" | |||
There was a problem hiding this comment.
this should probably get the last release version from git (grep for version: bump?)
|
overall seems like the right direction |
|
@heyitsanthony All addressed. Test can now run with PTAL. Thanks. |
|
|
||
| // TestReleaseMigrate ensures that changes to master branch does not affect the | ||
| // migration from latest etcd releases. | ||
| func TestReleaseMigrate(t *testing.T) { |
There was a problem hiding this comment.
TestReleaseUpgrade? this is not migration, right?
|
@xiang90 Just added Thanks! |
gyuho
changed the title
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For coreos#5697.