From 246862c33f520f6a77183690d51d3c81063fdd02 Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Thu, 30 Apr 2020 10:43:40 -0400 Subject: [PATCH] kola/testiso: test that default path is fully offline I'd like to get coverage for https://github.com/coreos/coreos-installer/pull/197 before it merges and we do a release with it. To do that, I want to test that the default installation path no longer requires Internet access. Here, "default" means we pass neither `--offline` nor `--stream` nor `--image-url` to `coreos-installer install`. Change the new `iso-offline-install` scenario to cover this; all we need to do is remove the explicit `--offline`. This scenario will only pass for now if the build under test has that PR and the live ISO has the osmet files (which right now is gated behind `--osmet`). Once that PR is in FCOS proper, we can make `--osmet` the default and this test will then always pass. --- mantle/platform/metal.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mantle/platform/metal.go b/mantle/platform/metal.go index 234791b2c8..1325391e50 100644 --- a/mantle/platform/metal.go +++ b/mantle/platform/metal.go @@ -552,7 +552,9 @@ func (inst *Install) InstallViaISOEmbed(kargs []string, liveIgnition, targetIgni var srcOpt string var serializedTargetConfig string if offline { - srcOpt = "--offline" + // note we leave srcOpt as "" here; offline installs should now be the + // default! + // we want to test that a full offline install works; that includes the // final installed host booting offline serializedTargetConfig = dataurl.EncodeBytes([]byte(renderedTarget))