Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close waits for the transactions to finish #80

Merged
merged 2 commits into from
Feb 14, 2018

Conversation

rcoelho
Copy link
Contributor

@rcoelho rcoelho commented Feb 14, 2018

DB.Close() actually waits for the transactions to finish now, since the PR 377.
boltdb/bolt#377

This PR updates the documentation.

DB.Close() actually waits for the transactions to finish now, since the PR 377.
boltdb/bolt#377
@codecov-io
Copy link

codecov-io commented Feb 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ee30b74). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage          ?   85.57%           
=========================================
  Files             ?        9           
  Lines             ?     1858           
  Branches          ?        0           
=========================================
  Hits              ?     1590           
  Misses            ?      158           
  Partials          ?      110
Impacted Files Coverage Δ
db.go 82.79% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee30b74...584b1a3. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Feb 14, 2018

lgtm

@xiang90 xiang90 merged commit b44cfbd into etcd-io:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants