Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Waf to WAF #373

Closed
anuraaga opened this issue Aug 31, 2022 · 0 comments · Fixed by #390
Closed

Rename Waf to WAF #373

anuraaga opened this issue Aug 31, 2022 · 0 comments · Fixed by #390

Comments

@anuraaga
Copy link
Contributor

In Go, it is customary for types to be named in all caps when they are acronyms, unlike many other languages. e.g., URL. It would be more idiomatic for our type to be named WAF instead of the current Waf.

This is a huge change so it could be considered ship has already sailed, but if doing it then before v3 is probably the time to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant