Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Transaction.ProcessRequest #283

Closed
jcchavezs opened this issue Jul 11, 2022 · 3 comments
Closed

Drop Transaction.ProcessRequest #283

jcchavezs opened this issue Jul 11, 2022 · 3 comments
Labels
Milestone

Comments

@jcchavezs
Copy link
Member

Summary

I'd like to propose to drop Transaction.ProcessRequest from the coraza package (see

func (tx *Transaction) ProcessRequest(req *http.Request) (*types.Interruption, error) {
). The reason is that it is too specific and makes assumptions about the usage of the library in the core package. Ideally this kind of specific helpers should go to another package or be an example.

On a side not, net/http package isn't supported by tinygo making this inconvenient, that was my original motivation for this request but if I could ignore this function in tiny_go, I believe this is a too specific function.

cc @jptosso @fzipi

@jptosso
Copy link
Member

jptosso commented Jul 11, 2022

I agree with moving this function and all transaction helpers to another package, like coraza/v3/utils/http

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Aug 11, 2022
@jptosso
Copy link
Member

jptosso commented Aug 18, 2022

Implemented in v3 #296

@jptosso jptosso closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants