Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Expose Tx timestamp. #1144

Open
s3rj1k opened this issue Sep 5, 2024 · 2 comments
Open

Feature: Expose Tx timestamp. #1144

s3rj1k opened this issue Sep 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@s3rj1k
Copy link

s3rj1k commented Sep 5, 2024

Consider exposing Timestamp https://github.com/corazawaf/coraza/blob/main/internal/corazawaf/transaction.go#L116 in types.Transaction interface.
@s3rj1k s3rj1k changed the title Expose Tx timestamp. Feature: Expose Tx timestamp. Sep 5, 2024
@fzipi fzipi added the enhancement New feature or request label Oct 5, 2024
@fzipi fzipi mentioned this issue Oct 21, 2024
Draft
@jcchavezs
Copy link
Member

Do you mind elaborating on the reason? What is the use case?

@s3rj1k
Copy link
Author

s3rj1k commented Oct 23, 2024

Do you mind elaborating on the reason? What is the use case?

I was working on TTL based cache for Tx, so having timestamp from actual transaction could benefit by reducing addition calls to time.Now() for getting same information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fzipi @jcchavezs @s3rj1k