-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing wasm artifact #237
Comments
IIUC, when releasing 0.2.0 @jcchavezs you created a new release, which created a tag, which built and created another release that is still in draft including the artifact. Actually I also like creating tags through the Draft a new release UI, but unfortunately our CI requires pushing a tag separately (wish GitHub had UI to just create a tag...) and then update the auto-created draft release with notes. To instead support create release from UI to trigger build workflow, we would want to change this to edit I guess, though it would mean strictly naming releases correctly I guess, not sure if it's worth it. https://github.com/corazawaf/coraza-proxy-wasm/blob/main/.github/workflows/ci.yaml#L165 |
I have copied the notes from the existing manual release to the CI one, deleted it, and published the CI one which includes the artifact (the tag hasn't changed so this is not a dangerous operation). Thanks for the report @Surya361! |
Nice finding @anuraaga I think it is worth to try the following: We check if the release exist, if not we just create a new release. In a next step we ALWAYS update the files to the release with
One thing to notice is that everytime you deal with releases, the identificator is the tag and that is conventional in our case. |
Hi,
Version 0.2.0 is missing wasm artifact in the repository
#177
The text was updated successfully, but these errors were encountered: