chore: fixes short write error.

[jcchavezs]

Related caddyserver/caddy#5952 (comment)

[jcchavezs]

So we have to define what to do here. The test fails as:

https://github.com/corazawaf/coraza-caddy/actions/runs/7002992650/job/19047820525#step:6:89

[Fail] could not do http request: Get "http://localhost:8080/response-headers?pass=leak": EOF

This is because before we were returning a content-length but the actual response body was empty (due to interruption) but caddy was returning nil and hence no error https://github.com/caddyserver/caddy/pull/5952/files#diff-a248c9a1ec018edea8b377d155bc1df1a642bf79d00ababb5cdacc6b86c5733dL968.

[M4tteoP]

What is the client receiving now that caddy is returning an error? Should we make the e2e-tester more error-tolerant?

[jcchavezs]

I think we should not fail because this is a legit request, we should just deny it.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jcchavezs]

PTAL @M4tteoP

[M4tteoP]

Looks good to me! And it is actually an approach that we already used #96 (comment).
The interceptor was originally copied from coraza upstream ( https://github.com/corazawaf/coraza/blob/main/http/interceptor.go), can these changes also be ported upstream? Also, vice-versa, we have corazawaf/coraza#923, corazawaf/coraza#925

[jcchavezs]

#923 I dont know but I am tempted to say yes #925 indeed, do you mind porting it?

…

On Mon, 27 Nov 2023, 23:46 Matteo Pace, ***@***.***> wrote: ***@***.**** approved this pull request. Looks good to me! And it is actually an approach that we already used #96 (comment) <#96 (comment)> . The interceptor was originally copied from coraza upstream ( https://github.com/corazawaf/coraza/blob/main/http/interceptor.go), can this changes also be ported upstream? Also, vice-versa, we have corazawaf/coraza#923 <corazawaf/coraza#923>, corazawaf/coraza#925 <corazawaf/coraza#925> — Reply to this email directly, view it on GitHub <#107 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAUCSRJY7XTC3FATTPTYGUJ2XAVCNFSM6AAAAAA74EDZDKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJRGU2TKMJVGQ> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>