Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autolock settings not working properly #3027

Closed
tomlinton opened this issue Feb 27, 2023 · 6 comments · Fixed by #3828
Closed

autolock settings not working properly #3027

tomlinton opened this issue Feb 27, 2023 · 6 comments · Fixed by #3828

Comments

@tomlinton
Copy link
Contributor

Lots of reports in Discord of autolock not behaving, maybe related to #2985

@wentokay
Copy link
Collaborator

wentokay commented Feb 28, 2023

are there any specific issues, or have you been able to reproduce anything you've seen?

I've found these searching for 'autolock' messages (since the last chrome store publish) -

"despite me having autolock set to off, i get locked out of backpack (i.e. needing a PW) everytime i click away" - #2985?
"It autolocks within in 2/3 mins" - #2985?
"autolocking is not working well" - ?

@tomlinton
Copy link
Contributor Author

Nothing specific, just needs digging into. It might all just be #2985.

@wentokay
Copy link
Collaborator

wentokay commented Feb 28, 2023

never will ask for a password after opening backpack if the service worker has died, i.e. it hasn't been polled with a keepalive message.

So this will always happen if the user quits the browser application itself and possibly if the user has backpack closed for a certain amount of time, although I haven't been able to reproduce that locally

If that's the case it might be best to remove never as an option altogether.

Other wallets using chrome manifest v2 won't have this problem because it's a special type of long-running background script and not a service worker that's designed to be ephemeral.

@tomlinton
Copy link
Contributor Author

Other reports:

I'm also using brave (on linux) and constantly have to enter password, regardless of lock settings

it the auto lock timer not fully operational yet? tried diff times and even never and it gets locked after closing regardless of setting

You can reproduce this behaviour with the Update on reload setting in dev tools, but I don't think that is what is happening here. It does seem like something is killing the service worker for some reason.

Screenshot 2023-03-02 at 9 21 37 AM

@wentokay
Copy link
Collaborator

wentokay commented Mar 1, 2023

chrome alarms might help in some cases but not in this case where the SW appears to be terminating with the popup

@armaniferrante
Copy link
Member

Going to change to p3. I'm not sure if there's anything we can do about this given the ephemeral nature of service workers. Please feel free to comment if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants