Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts: Browser detection should not depend on BROWSER environment variable #1232

Closed
aximili-dev opened this issue Jan 4, 2022 · 3 comments
Closed

ts: Browser detection should not depend on BROWSER environment variable #1232

aximili-dev opened this issue Jan 4, 2022 · 3 comments

Comments

@aximili-dev
Copy link
Contributor

aximili-dev commented Jan 4, 2022 •
edited
Loading

In /ts/src/utils/common.ts the BROWSER environment variable is used to determine if the program is running inside a web browser, however, it is common practice for GNU/Linux distros to use it to specify which app should be used to open web links.

As an example this causes issues when trying to connect to a localnet, since the local provider is not available inside a browser. If the fix is as easy as removing this line I'd be happy to submit a pull request with just that.
@aximili-dev aximili-dev mentioned this issue Jan 4, 2022
Merged
@akutruff
Copy link

akutruff commented Jan 5, 2022

Similar issue: #1145

@aximili-dev
Copy link
Contributor Author

Similar to #1145

@plbstl plbstl mentioned this issue Jan 8, 2022
Closed
@ndrewtl
Copy link

ndrewtl commented Jun 15, 2022

I'm running into this in anchor-cli 0.24.2. It doesn't seem to have been fixed. Can we reopen the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akutruff @ndrewtl @aximili-dev