Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine delayed send #481

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Refine delayed send #481

merged 5 commits into from
Nov 25, 2024

Conversation

ticruz38
Copy link
Collaborator

NoteCreate:

  • Close the modal once the event is signed
  • Re-open the modal when/if the sent is cancelled
  • Keep an entry in the draft store with id "note-create" to keep the note content during the modal lifecycle

NoteReply:

  • Save the draft if the send is cancelled
  • Align the note content text with the countdown text
  • loading start at 20% to the left, the loading bar is now tweened animated rather than spring animated, for a smoother look
  • The loading bar has a lighter background now as Daniele's screenshot
  • When a Note is being replied, a reply with a background accent appear on the parent note, per Daniele's screenshot.
  • The thing missing from Daniele's screenshot is the action popover next to the loading bar, the note actions (deleted, broadcast repost etc) can only be used once the event is actually uploaded to one relay, so it should probably slide in before the upload is complete, let me know if I should add it anyway.

@ticruz38
Copy link
Collaborator Author

#480

@staab
Copy link
Collaborator

staab commented Nov 21, 2024

A few small things:

  • "Sending in x seconds" shows one fewer than it should. So if your timeout is 5, it starts with 4, and shows 0 for one second.
  • NoteReply should automatically open again after canceling send.
  • Where did you get the orange reply button? I don't see it in the mockups here at least. Anyway, we should just leave this as it was.
  • The reply bar still doesn't look like the mockups. It's missing the outline, and the gradient doesn't fade to the card's background color
Screen.Recording.2024-11-21.at.11.18.57.AM.mov
Screen.Recording.2024-11-21.at.11.25.14.AM.mov

removeDraft = () => cb() && repository.removeEvent(event.id)
removeDraft = () => {
cb()
repository.removeEvent(event.id)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're using publishThunk, this shouldn't be necessary, welshman does it automatically.

@ticruz38
Copy link
Collaborator Author

  • I made this change so that the countdown does go to zero, it's a Math.ceil, If I start at 5 the note will send at 1
  • the orange reply button is in the @dtonon mockup, not sure how to display/use it, my understanding is to show it when the note is being replied
  • damn I thought I had the reply loading bar right this time

@ticruz38
Copy link
Collaborator Author

  • Reply button is gone
  • NoteReply does reopen on cancel

On your last point I'm confused, are you speaking of the loading bar?

Daniele's mockup
Screenshot 2024-11-22 at 18 02 03

App rendering
Screenshot 2024-11-22 at 17 50 26

The gradient goes from var(--accent) to transparent, I don't see an outline in Daniele's design, I might be looking at the wrong thing though

@staab
Copy link
Collaborator

staab commented Nov 22, 2024

My bad, I was looking at your first version as the authoritative mockup 🤦‍♂️ What you have now looks fine, the one thing would be to add something to the state pre-publish, which looks pretty naked. I like what you had originally, with the outline matching the button color

@ticruz38 ticruz38 force-pushed the refine-delayed-send branch from b7d9ec3 to b2a2e9d Compare November 25, 2024 10:24
Comment on lines +78 to +85
<span
>Published to {success}/{total}
{#if failed > 0 || timeout > 0}
({failed > 0 ? failed + " failed" : ""}{timeout > 0
? (failed > 0 ? ", " : "") + timeout + " timed out"
: ""})
{/if}
</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TERNARY MADNESS

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯
I agree, I'll make a function in the script

@staab staab merged commit d24dd0b into coracle-social:dev Nov 25, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants