-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine delayed send #481
Refine delayed send #481
Conversation
A few small things:
Screen.Recording.2024-11-21.at.11.18.57.AM.movScreen.Recording.2024-11-21.at.11.25.14.AM.mov |
src/app/shared/Note.svelte
Outdated
removeDraft = () => cb() && repository.removeEvent(event.id) | ||
removeDraft = () => { | ||
cb() | ||
repository.removeEvent(event.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're using publishThunk
, this shouldn't be necessary, welshman does it automatically.
|
My bad, I was looking at your first version as the authoritative mockup 🤦♂️ What you have now looks fine, the one thing would be to add something to the state pre-publish, which looks pretty naked. I like what you had originally, with the outline matching the button color |
b7d9ec3
to
b2a2e9d
Compare
<span | ||
>Published to {success}/{total} | ||
{#if failed > 0 || timeout > 0} | ||
({failed > 0 ? failed + " failed" : ""}{timeout > 0 | ||
? (failed > 0 ? ", " : "") + timeout + " timed out" | ||
: ""}) | ||
{/if} | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TERNARY MADNESS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
I agree, I'll make a function in the script
NoteCreate:
NoteReply: