attribute / shell-attribute confusion?

[Zimmi48]

From the documentation in config.nix, it would seem that nix-build and nix-shell (without arguments) should target a different attribute if attribute and shell-attribute are both set and differ. Yet, (at least with the latest coq-nix-toolbox) both commands actually target the shell-attribute. Should we fix the toolbox or the documentation?

[CohenCyril]

Thanks for raising the question, I had not noticed. These two attributes date back to the time where it was impossible to build other derivations. But now we can, somehow attribute is now only used to make the CI now which package to consider for rev deps...
Hence, I think we should fix the doc, and see these two attributes as a documentation that there is a divergence between the end-user package and the dev environement, while nix-build without argument should be in sync with nix-shell.

[Zimmi48]

As I understand it, attribute is providing a default value for bundles' main job. This led me to proposing the simplification at #40.

Do you confirm that we should also fix the documentation appearing here:

coq-nix-toolbox/template-config.nix

Line 67 in e747bcb

## by default the current package and its shell attributes are main jobs

I.e., is it correct that the shell-attribute is not a main job and not included by default in a bundle?

[CohenCyril]

Yes, it is

coq-nix-toolbox/config-parser-1.0.0/default.nix

Lines 27 to 30 in e747bcb

	(setAttrByPath config.shell-ppath
	{ override.version = "${config.src}";
	job = config.shell-attribute;
	main-job = true; })

But maybe it shouldn't?

[Zimmi48]

But then how come that my patch in #40, which removed coqPackages.coq-shell.job = false, still generates the same workflows?

[CohenCyril]

Yep, I'm confused too.