Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage of setsockopt TCP_NODELAY #357

Closed
Piscolero opened this issue May 16, 2017 · 3 comments
Closed

Incorrect usage of setsockopt TCP_NODELAY #357

Piscolero opened this issue May 16, 2017 · 3 comments
Labels

Comments

@Piscolero
Copy link

The function net_open_eth() in src/net.c calls setsockopt with level SOL_SOCKET and option TCP_NODELAY. If you want to set TCP_NODELAY, the level has to be IPPROTO_TCP. The call now actually sets SO_DEBUG.

@jobezic
Copy link
Member

jobezic commented Jun 13, 2017

Can you make a pull request, please?

@matahr
Copy link

matahr commented Jun 17, 2017

Kernel 4.10.0-22-generic #24-Ubuntu SMP x86_64 GNU/Linux

chilli[21080]: 92 setsockopt(s=2, level=6, optname=1, optlen=4) failed
chilli[21080]: Failed to create dhcp listener on eth0

@Piscolero
Copy link
Author

Well, it's probably returning ENOPROTOOPT in this case, because it's not a tcp socket.
So I think the setting should be avoided at all since it never worked before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants