Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text size #8

Open
jfmoyen opened this issue Dec 13, 2023 · 0 comments
Open

Text size #8

jfmoyen opened this issue Dec 13, 2023 · 0 comments

Comments

@jfmoyen
Copy link

jfmoyen commented Dec 13, 2023

If I'm not mistaken, geom_text_z() does not honour the size aesthetics. I'm not too good at parsing ggplot geom's code, but it seems to me that draw_panel for GeomTextZ does not use the size arrgument (nor ... as far as I can see). Line 125, I think:

text3d_rgl_calls <- lapply(seq(nrow(data)), function(i) {
cryogenic::capture_call(
rgl_text_helper(
str = lab[i],
x = data$x[i],
y = data$y[i],
z = data$z[i],
rot = 0,
state = NULL,
manual = TRUE,
colour = data$colour[i],
orientation = orientation
),
defaults = material
)
})

Shouldn't the rgl_text_helper take something like size = data$size[i] ?

Thanks (and congrats for a cool job, and very usable too !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant