Skip to content

Commit

Permalink
ref(collectors)!: rename metrics
Browse files Browse the repository at this point in the history
BREAKING CHANGE: rename viwer_count to viewer_total
BREAKING CHANGE: rename subscribers_count to subscribers_total

Renamed metrics to be in-line to prometheus metrics naming best practices
  • Loading branch information
coolapso committed Aug 12, 2024
1 parent cd5a166 commit 9f3ec8a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/collectors/exporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,13 @@ func newMetrics() *metrics {
),

viewerCount: prometheus.NewDesc(
prometheus.BuildFQName(namespace, "", "viewer_count"),
prometheus.BuildFQName(namespace, "", "viewer_total"),
"Channel current viewer count",
[]string{"name"}, nil,
),

subCount: prometheus.NewDesc(
prometheus.BuildFQName(namespace, "", "subscribers_count"),
prometheus.BuildFQName(namespace, "", "subscribers_total"),
"Channel current total subscribers",
[]string{"name"}, nil,
),
Expand Down

0 comments on commit 9f3ec8a

Please sign in to comment.