add menu item description

[anoblet]

No description provided.

[lkraav]

@anoblet it seems cxl-app-layout work has been pushed into this PR? I'd like to have another look at the menu item description solution and see if I can merge it.

Can you rebase to latest and re-push?

[anoblet]

@lkraav Fixed!

[lkraav]

Fixed!

Thanks, but are there a bunch of eslint auto-fix changes in here, or is your code editor doing something? Can you attempt a clean "relevant changes only" commit?

[anoblet]

The es-lint auto fixes are part of the pre-commit hook. Apart from editing the file in Github, I'm not sure how to disable them.

[lkraav]

The es-lint auto fixes are part of the pre-commit hook. Apart from editing the file in Github, I'm not sure how to disable them.

I find it curious that running yarn lint does not produce the same changes 🤔

You can commit without linters using --no-verify.

[lkraav]

I find it curious that running yarn lint does not produce the same changes thinking
You can commit without linters using --no-verify.

It's prettier making these changes, but it isn't part of lint script.

I'll see if I can run it on codebase manually so we can get the baseline fixed.

[lkraav]

OK rebase on latest master, let's see what that looks like.

[anoblet]

Looks a lot cleaner now.

[lkraav]

Hmm, in latest FF, I get an exception and menu loading crashes

18:32:07.213 Uncaught (in promise) TypeError: Invalid attempt to spread non-iterable instance.
In order to be iterable, non-array objects must have a [Symbol.iterator]() method.
    _nonIterableSpread main.d5be0d923e9eb240271c.bundle.js:2596
    _toConsumableArray main.d5be0d923e9eb240271c.bundle.js:2592
    _updatedContextMenuItems cxl-marketing-nav.js:281
    _updatedContextMenuItems cxl-marketing-nav.js:268
    _updatedContextMenuItems cxl-marketing-nav.js:267
    updated cxl-marketing-nav.js:201
    performUpdate updating-element.ts:791
    _callee$ updating-element.ts:724
    tryCatch runtime.js:63
    invoke runtime.js:293
    defineIteratorMethods runtime.js:118
    asyncGeneratorStep vendors~main.d5be0d923e9eb240271c.bundle.js:63771
    _next vendors~main.d5be0d923e9eb240271c.bundle.js:63793
main.d5be0d923e9eb240271c.bundle.js:2596:9

[anoblet]

Fixed

[kylebrodeur]

Task linked: CU-2x7c7dv Aybolit - Nav Menu items description feature.

[saas786]

closed in favour of #220