Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to set old values when element has been removed from the model. #266

Open
mmacfadden opened this issue Feb 4, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@mmacfadden
Copy link
Contributor

Versions

  • Convergence Version: 1.0.0-rc.12

Describe the Bug
The code here:

https://github.com/convergencelabs/convergence-server/blob/8ded7fa5adaac3690520c98f53b0843072adab7d/src/main/scala/com/convergencelabs/convergence/server/backend/services/domain/model/RealtimeModel.scala#L239

Will insert None values or bogus values into the applied operations if the operation is noop'ed and the real time element is not in the model anymore.

Expected Behavior
We have discussed potentially keeping deleted elements around in a recycle bin while conflicting operations could still come in.

@mmacfadden mmacfadden added the bug Something isn't working label Feb 4, 2022
@mmacfadden
Copy link
Contributor Author

Another option is to update the schema to allow for null values in this condition. Right now we have the combination of not being able to compute the old value, but the database needing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant