feat: publish only if commit+push succeed (#229)

conventional-changelog · Jan 3, 2018 · c5e1ee2 · c5e1ee2
1 parent 45fcad5
commit c5e1ee2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ _how it works:_
 3. when you're ready to release to npm:
   1. `git checkout master; git pull origin master`
   2. run `standard-version`
-  3. `git push --follow-tags origin master; npm publish`
+  3. `git push --follow-tags origin master && npm publish`
 
 `standard-version` does the following:
 

diff --git a/lib/lifecycles/tag.js b/lib/lifecycles/tag.js
@@ -27,7 +27,7 @@ function execTag (newVersion, pkgPrivate, args) {
   return runExec(args, 'git tag ' + tagOption + args.tagPrefix + newVersion + ' -m "' + formatCommitMessage(args.message, newVersion) + '"')
     .then(() => {
       var message = 'git push --follow-tags origin master'
-      if (pkgPrivate !== true) message += '; npm publish'
+      if (pkgPrivate !== true) message += ' && npm publish'
       if (args.prerelease !== undefined) message += ' --tag prerelease'
 
       checkpoint(args, 'Run `%s` to publish', [message], chalk.blue(figures.info))