Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension always turns off autowiring for existing cache storage #50

Open
jankonas opened this issue Nov 11, 2023 · 0 comments
Open

Extension always turns off autowiring for existing cache storage #50

jankonas opened this issue Nov 11, 2023 · 0 comments

Comments

@jankonas
Copy link
Contributor

While registering own storage(s) this extension always turns off autowiring for the existing storage (ie. FileStorage or any else):

if ($storages === 0) {
	$builder->getDefinitionByType(IStorage::class)
		->setAutowired(false);
}

When there is no default connection configured, this leaves the DI container without autowired cache storage. Shouldn't the condition be changed to:

if ($connection->storageAutowired ?? $autowired) {
	$builder->getDefinitionByType(IStorage::class)
		->setAutowired(false);
}

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant