-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nette Decorator, Search & DBAL extensions #37
Comments
Can you add SearchExtension to the first extensions? I guess it's the most reliable solution and we cannot solve it in nettrine/dbal https://github.com/nette/di/blob/master/src/DI/Compiler.php#L215 |
I am not sure, what that is going to solve? The problem is that in nette/di@master decorator extension is processed in the end - after the DBAL's extension. So tags added via decorator are not taken into account in DBAL's extension beforeCompile method, which is registering subscribers to eventManager. |
Oh, I see. |
@f3l1x What do you think? |
As I describe here: nette/di#215 (comment) I am using it for Subscribers, which have interface
Listeners do not have interfaces, but these are registred via annotations
|
Sorry, I just noticed it too. Not sure why we choosed tags before 🤔 |
Solved by #38 |
Nette DI in master register Decorator extension as last, which fixes the problem if somebody register subscribers via Search extension. But new problem occurs, since now Decorator beforeCompile is run after DBAL's beforeCompile, therefore Subscribers do not have tag yet.
nette/di#215 (comment)
The text was updated successfully, but these errors were encountered: