-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats - add queues: {name: size} info on /stat #197
Conversation
behavior similar to the sidekiq: '/stat/queues'
Perfect, thank you for adding a test. 👍 |
server/server.go
Outdated
func (s *Server) CurrentQueueState() (map[string]interface{}, error) { | ||
|
||
queues := make(map[string]interface{}) | ||
s.Store().EachQueue(func(q storage.Queue) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather you push this logic down into the Handler and not create a public API for it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, move this code into statsQueueHandler.
I would instead suggest that you add these elements to |
Yeah sure 👍 one stat to get it all. I was just following up with that of sidekiq. |
I have pushed the changes. please review. btw, I have placed queues inside faktory like: I mean this
|
1c9f857
to
2e4bbbd
Compare
…licit default queue size, #197
This PR is for queue info addition on /stats endpoint.
Motivation
Faktory was missing the json stats endpoint about queues like in sidekiq.
Edit Jan 11: queues map is moved into /stats inside faktory.queues
Remarks
Not sure if I should write test for this or change other files. The existing test are passing as usual 😁Added test too :)